front: unify PathStep and SuggestedOP matching #9289
+45
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alice Khoudli <[email protected]>
In many spots we need to match a PathStep with a SuggestedOP. Each spot is a special snowflake and needs its own little variation of the matching logic. formatSuggestedViasToRowVias() needs to match KP and PathStep.id, but that's undesirable for other spots. Extract the extra special matching near the spot it's needed. In following commits matchPathStepAndOp() will be re-used in more spots. No behavior change, only refactoring. Signed-off-by: Simon Ser <[email protected]>
The logic in matchPathStepAndOp() is more general. Signed-off-by: Simon Ser <[email protected]>
The logic in matchPathStepAndOp() is more general. pathStepMatchesOp() performs some special checks on kp/name/opId so retain these. Also need to adapt the argument type for matchPathStepAndOp() to only pick the properties we really need. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/refacto-pathstep-op-matching
branch
from
f84c3e2
to
bf9dc79
Compare
Synar
reviewed
Oct 10, 2024
emersion
commented
Oct 11, 2024
Synar
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Ref #9276 (comment)
Depends on #9276